format: don't fail silently on invalid input anymore #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When trying to format a file containing a single |
|
In fact I noticed that unexpected end of file doesn't seem to cause any error, and the file is also actually formatted (although the last unclosed block is a bit messed up sometime). So something (Topiary, tree-sitter, or the Nickel grammar) is probably wired to handle incomplete input. However, if you add an expression like |
vkleen
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nickel formatis silently doing nothing and exit with success code when the input file doesn't parse, which can be surprising (you think that you correctly formatted your codebase, but in fact the file doesn't even parse). This is due to usingtolerate_parsing_errors: true, which as reported by @vkleen was a fix for a time when Topiary would simply erase some files upon parsing errors, which was of course problematic, to say the least.This isn't the case anymore, and thus we can get rid of this option and correctly report parse errors when formatting.